Fix X11 and Wayland - Images opened in unfocussed Tmux window overlaid on top of active window/session #215
Conversation
…in image being generated in the focussed window and session, and in the wrong position. - Remove spurius include for the utilities std library, introduced in PR jstkdng#212
…and add support for wayland
|
|
I found that you are also working on ueberzugpp-new, likely a refactor of this branch.Since tmux integration is likely to also be relevant in the new project, my two cents are to make the initial image visibility state independent of the image display method (wayland, X11, etc.). In other words, don't let equivalent to X11 or Wayland modules show or hide images after initialization. Simply delegate showing/hiding the image state to the app, so that it can decide when to show or hide images independently. |
|
yeah, it's a refactor of the whole project, a lot of technical debt here.
Most applications that use u++ just send either add or remove commands, they just want auto preview managing. I do wonder why old |
|
I just tried this changes and it broke another functionality that works with regular ueberzug. When you have two tmux clients connected to the same session and you open |
|
Thanks for checking. I can have a look, but likely only next week, since I'm travelling atm. |
Fixes issue 213, on both Wayland and X11.
Note that for X11, a small change to
add_imageinx11.cppwas still required, to ensure no flickering (even if just for an instant) in the active session/window when initializing a new image in an unfocussed session/window. I tested in Wayland, and no change of that module was required in that case.ueberzugppin an unfocussed window or session results in image being generated on top of the focussed window and session, instead of hidden in the correct ones, and also in the wrong position.Additionally:
utilitieslibrary, introduced in PR #212